Bug 52284

Summary: Split Host object off from WebKitPatch for easier re-use
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, levin, mihai, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Eric Seidel (no email) 2011-01-12 02:46:51 PST
Split Host object off from WebKitPatch for easier re-use
Comment 1 Eric Seidel (no email) 2011-01-12 02:47:47 PST
Created attachment 78669 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-12 02:49:19 PST
Should be trivial to write additional scripts which use webkitpy (including steps and command objects) w/o being webkit-patch now.
Comment 3 Adam Barth 2011-01-12 02:57:05 PST
Comment on attachment 78669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78669&action=review

We should probably rename all the tool variables / properties to host.

> Tools/Scripts/webkitpy/common/host.py:30
> +# Command objects expect to have a self.tool which provides these interfaces.

Command objects aren't a concept that make sense in common.  I'd just remove this comment.

> Tools/Scripts/webkitpy/common/host.py:44
> +        self.bugs = bugzilla.Bugzilla()
> +        self.buildbot = buildbot.BuildBot()
> +        self.executive = executive.Executive()

Why don't we just import these names directly instead of using this goofy syntax?

> Tools/Scripts/webkitpy/common/host.py:81
> +    def command_completed(self):
> +        if self._irc:
> +            self._irc.disconnect()

This probably needs a more semantic name like disconnect_from_irc

> Tools/Scripts/webkitpy/tool/main.py:36
> +from webkitpy.common.host import Host

Shouldn't this be alphabetized like everything else?
Comment 4 Eric Seidel (no email) 2011-01-21 01:37:00 PST
Created attachment 79709 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-01-21 03:23:56 PST
Comment on attachment 79709 [details]
Patch for landing

Clearing flags on attachment: 79709

Committed r76339: <http://trac.webkit.org/changeset/76339>
Comment 6 WebKit Commit Bot 2011-01-21 03:24:01 PST
All reviewed patches have been landed.  Closing bug.