Bug 52284 – Split Host object off from WebKitPatch for easier re-use

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Split Host object off from WebKitPatch for easier re-use

[Eric Seidel (no email)]

Created attachment 78669 [details]
Patch

[Eric Seidel (no email)]

Should be trivial to write additional scripts which use webkitpy (including steps and command objects) w/o being webkit-patch now.

[Adam Barth]

Comment on attachment 78669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78669&action=review

We should probably rename all the tool variables / properties to host.

> Tools/Scripts/webkitpy/common/host.py:30
> +# Command objects expect to have a self.tool which provides these interfaces.

Command objects aren't a concept that make sense in common.  I'd just remove this comment.

> Tools/Scripts/webkitpy/common/host.py:44
> +        self.bugs = bugzilla.Bugzilla()
> +        self.buildbot = buildbot.BuildBot()
> +        self.executive = executive.Executive()

Why don't we just import these names directly instead of using this goofy syntax?

> Tools/Scripts/webkitpy/common/host.py:81
> +    def command_completed(self):
> +        if self._irc:
> +            self._irc.disconnect()

This probably needs a more semantic name like disconnect_from_irc

> Tools/Scripts/webkitpy/tool/main.py:36
> +from webkitpy.common.host import Host

Shouldn't this be alphabetized like everything else?

[Eric Seidel (no email)]

Created attachment 79709 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 79709 [details]
Patch for landing

Clearing flags on attachment: 79709

Committed r76339: <http://trac.webkit.org/changeset/76339>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.