Bug 52283

Summary:

Remove premature optimization from SchemeRegistry

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Adam Barth

Reported 2011-01-12 02:15:35 PST

Remove premature optimization from SchemeRegistry

Attachments
Patch (1.75 KB, patch) 2011-01-12 02:18 PST, Adam Barth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-01-12 02:18:38 PST

Created attachment 78666 [details] Patch

Adam Barth

Comment 2 2011-01-12 02:59:52 PST

This code looks to have been added in http://trac.webkit.org/changeset/19952, which doesn't explain why this optimization is necessary.

Adam Barth

Comment 3 2011-01-12 03:00:18 PST

There might be more information in rdar://problem/4922454, but I can't see it.

Darin Adler

Comment 4 2011-01-12 14:12:07 PST

(In reply to comment #3) > There might be more information in rdar://problem/4922454, but I can't see it. That’s a security bug, so I can give some details here, but probably best to do so in a security-sensitive bug.

Adam Barth

Comment 5 2011-01-12 15:13:35 PST

I'm marking this bug as security sensitive, not because this issue reflects a security issue but so we can discuss the original motivation for the code we're changing.

Darin Adler

Comment 6 2011-01-12 16:21:49 PST

Radar bug 4922454 was about http-protocol HTML files being able to load file-protocol scripts. The information in Radar does not any insight into why the fix included the optimized path. Sorry, didn’t mean to be a tease. I suppose this really isn’t all that security-sensitive. I was rushing and doing multiple things at once and really noticed only that the classification was security.

Adam Barth

Comment 7 2011-01-12 16:25:14 PST

Thanks for looking in rdar. I'm going to move this back to non-sensitive so the commit-queue can land the patch.

WebKit Commit Bot

Comment 8 2011-01-12 17:40:06 PST

Comment on attachment 78666 [details] Patch Clearing flags on attachment: 78666 Committed r75664: <http://trac.webkit.org/changeset/75664>

WebKit Commit Bot

Comment 9 2011-01-12 17:40:11 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.