Bug 52280

Summary:

[GStreamer] support in mac video fullscreen controller

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed patch	none
proposed patch	eric: review-
proposed patch	none
proposed patch	eric.carlson: review+

Philippe Normand

Reported 2011-01-12 01:34:24 PST

Support for GStreamer platformMedia is missing in WebView/WebVideoFullscreenController.mm

Attachments
proposed patch (4.35 KB, patch) 2011-01-12 01:36 PST, Philippe Normand	no flags	Details Formatted Diff Diff
proposed patch (4.52 KB, patch) 2011-01-12 01:47 PST, Philippe Normand	eric: review-	Details Formatted Diff Diff
proposed patch (6.32 KB, patch) 2011-03-01 00:23 PST, Philippe Normand	no flags	Details Formatted Diff Diff
proposed patch (6.34 KB, patch) 2011-03-01 00:29 PST, Philippe Normand	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2011-01-12 01:36:26 PST

Created attachment 78663 [details] proposed patch

WebKit Review Bot

Comment 2 2011-01-12 01:39:30 PST

Attachment 78663 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit/mac/ChangeLog', u'WebKit/mac/WebVie..." exit_code: 1 WebKit/mac/WebView/WebVideoFullscreenController.mm:112: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:113: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:114: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:150: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:151: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Philippe Normand

Comment 3 2011-01-12 01:47:45 PST

Created attachment 78664 [details] proposed patch

Philippe Normand

Comment 4 2011-02-18 07:01:46 PST

Eric, when you get time can you please look at this patch? Thanks!

Eric Seidel (no email)

Comment 5 2011-02-18 12:32:01 PST

Comment on attachment 78664 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=78664&action=review Seems we could use functions to abstract away some of this, no? > WebKit/mac/WebView/WebVideoFullscreenController.mm:117 > + [window setHasShadow:YES]; // This is nicer with a shadow. > + [window setLevel:NSPopUpMenuWindowLevel-1]; Seems this is shared with the QT path, no?

Philippe Normand

Comment 6 2011-03-01 00:23:04 PST

Created attachment 84196 [details] proposed patch

WebKit Review Bot

Comment 7 2011-03-01 00:26:28 PST

Attachment 84196 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:108: Line contains tab character. [whitespace/tab] [5] Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:109: Line contains tab character. [whitespace/tab] [5] Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:110: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Philippe Normand

Comment 8 2011-03-01 00:29:04 PST

Created attachment 84198 [details] proposed patch

Philippe Normand

Comment 9 2011-03-02 08:58:11 PST

Thanks Eric, both of you :) Committed r80136: <http://trac.webkit.org/changeset/80136>

Note You need to log in before you can comment on or make changes to this bug.