Bug 52257

Summary:

Change createObjectURL and revokeObjectURL to put under webkitURL

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore JavaScript

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, fishd, gustavo, levin, webkit-ews, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Proposed Patch	jianli: commit-queue-
Proposed Patch	jianli: commit-queue-
Proposed Patch	fishd: review+, jianli: commit-queue-

Jian Li

Reported 2011-01-11 15:26:39 PST

Change createObjectURL and revokeObjectURL to put under webkitURL, per the latest version of File API. Note that we add "webkit" vendor prefix to URL.

Attachments
Proposed Patch (38.72 KB, patch) 2011-01-11 15:31 PST, Jian Li	jianli: commit-queue-	Details Formatted Diff Diff
Proposed Patch (39.16 KB, patch) 2011-01-11 16:08 PST, Jian Li	jianli: commit-queue-	Details Formatted Diff Diff
Proposed Patch (38.75 KB, patch) 2011-01-11 16:39 PST, Jian Li	fishd: review+ jianli: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2011-01-11 15:31:50 PST

Created attachment 78610 [details] Proposed Patch

Early Warning System Bot

Comment 2 2011-01-11 15:59:06 PST

Attachment 78610 [details] did not build on qt: Build output: http://queues.webkit.org/results/7442120

Jian Li

Comment 3 2011-01-11 16:08:02 PST

Created attachment 78615 [details] Proposed Patch Fixed qt build.

WebKit Review Bot

Comment 4 2011-01-11 16:29:08 PST

Attachment 78610 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7393154

Jian Li

Comment 5 2011-01-11 16:39:21 PST

Created attachment 78620 [details] Proposed Patch Another fix for qt build.

Darin Fisher (:fishd, Google)

Comment 6 2011-01-12 11:52:16 PST

Comment on attachment 78620 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78620&action=review > Source/WebCore/DerivedSources.cpp:97 > +#include "JSDOMUrl.cpp" nit: I think webkit style is for acronyms in identifiers/names to be either lowercase (if at the start of a name) or UPPERCASE, so this should be JSDOMURL.cpp. > Source/WebCore/DerivedSources.make:150 > + DOMUrl \ nit: DOMURL

Jian Li

Comment 7 2011-01-13 14:56:44 PST

Renamed to DOMURL and committed as https://trac.webkit.org/changeset/75739.

Note You need to log in before you can comment on or make changes to this bug.