Summary: | Change createObjectURL and revokeObjectURL to put under webkitURL | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jian Li <jianli> | ||||||||
Component: | WebCore JavaScript | Assignee: | Jian Li <jianli> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, fishd, gustavo, levin, webkit-ews, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Jian Li
2011-01-11 15:26:39 PST
Created attachment 78610 [details]
Proposed Patch
Attachment 78610 [details] did not build on qt: Build output: http://queues.webkit.org/results/7442120 Created attachment 78615 [details]
Proposed Patch
Fixed qt build.
Attachment 78610 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7393154 Created attachment 78620 [details]
Proposed Patch
Another fix for qt build.
Comment on attachment 78620 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78620&action=review > Source/WebCore/DerivedSources.cpp:97 > +#include "JSDOMUrl.cpp" nit: I think webkit style is for acronyms in identifiers/names to be either lowercase (if at the start of a name) or UPPERCASE, so this should be JSDOMURL.cpp. > Source/WebCore/DerivedSources.make:150 > + DOMUrl \ nit: DOMURL Renamed to DOMURL and committed as https://trac.webkit.org/changeset/75739. |