Bug 52252

Summary:

[Qt] Use a black background color for the video element on Qt Mobile

Product:

WebKit

Reporter:

Yi Shen <max.hong.shen>

Component:

WebKit Qt

Assignee:

Yi Shen <max.hong.shen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue, eric, hausmann, kling, nancy.piedra, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
first try	none

Yi Shen

Reported 2011-01-11 14:14:09 PST

According to the UI specification for Html5 inline video on Symbian, if there is no poster defined or video frame data is available, the webpage should display a black box which fits the video element area. The easiest implementation is to use a black background color for the video element. I will add a patch for review soon. Comments & Suggestions are super welcome! :)

Attachments
first try (1016 bytes, patch) 2011-01-11 17:12 PST, Yi Shen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yi Shen

Comment 1 2011-01-11 17:12:29 PST

Created attachment 78629 [details] first try

Yi Shen

Comment 2 2011-01-12 13:52:08 PST

Eric, could you also please take a look at this patch? Thx

Eric Seidel (no email)

Comment 3 2011-01-12 14:02:58 PST

Comment on attachment 78629 [details] first try I mean, I know nothing about this. But I'm willing to rs=me this patch.

Eric Seidel (no email)

Comment 4 2011-01-12 14:06:39 PST

In general the other eric knows a lot more about <video> and <audio> related stuff. I'm not sure he has much opinion on how <video> looks on symbian (i'm not sure any of us who don't work on symbian really care).

Yi Shen

Comment 5 2011-01-12 14:18:42 PST

(In reply to comment #4) > In general the other eric knows a lot more about <video> and <audio> related stuff. I'm not sure he has much opinion on how <video> looks on symbian (i'm not sure any of us who don't work on symbian really care). Thanks Eric :) I am going to ask other qt/symbian guys for some comments.

Andreas Kling

Comment 6 2011-01-13 06:49:08 PST

Comment on attachment 78629 [details] first try cq=me ;)

WebKit Commit Bot

Comment 7 2011-01-13 07:29:36 PST

Comment on attachment 78629 [details] first try Clearing flags on attachment: 78629 Committed r75712: <http://trac.webkit.org/changeset/75712>

WebKit Commit Bot

Comment 8 2011-01-13 07:29:43 PST

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 9 2011-01-13 10:57:56 PST

Revision r75712 cherry-picked into qtwebkit-2.2 with commit b92afdd <http://gitorious.org/webkit/qtwebkit/commit/b92afdd>

Note You need to log in before you can comment on or make changes to this bug.