Bug 52235

Summary: [chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, jamesr, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch jamesr: review+, kbr: commit-queue-

Kenneth Russell
Reported 2011-01-11 12:16:08 PST
In http://trac.webkit.org/changeset/65093 , Chromium's in-process WebGL implementation was changed to use Chromium's GL bindings rather than the GLEW library. Unfortunately, I did not realize at the time that this introduced an undesirable circular dependency between Chromium and WebKit. The solution is to move this class from the WebKit repository to the Chromium repository. The Chromium-side changes have been landed in http://src.chromium.org/viewvc/chrome?view=rev&revision=71069 .
Attachments
Patch (80.96 KB, patch)
2011-01-11 13:43 PST, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2011-01-11 13:43:22 PST
Created attachment 78590 [details] Patch
James Robinson
Comment 2 2011-01-11 14:10:35 PST
Comment on attachment 78590 [details] Patch R=me. deletion rules!
Kenneth Russell
Comment 3 2011-01-11 14:16:52 PST
Committed r75553: <http://trac.webkit.org/changeset/75553>
Note You need to log in before you can comment on or make changes to this bug.