Bug 52231

Summary: [WKView setFrameSize:] derefs _page->drawingArea() without null check
Product: WebKit Reporter: John Sullivan <sullivan>
Component: WebKit2Assignee: John Sullivan <sullivan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch that adds a null check. andersca: review+

Description John Sullivan 2011-01-11 11:55:04 PST 
[WKView setFrameSize:]  dereferences _data->_page->drawingArea() without testing for null. But the drawing area can be null just after a WKView is created, due to a recent change.
Comment 1 John Sullivan 2011-01-11 11:56:22 PST 
Created attachment 78572 [details]
Patch that adds a null check.
Comment 2 John Sullivan 2011-01-11 12:06:06 PST 
Fixed in r75525.
Comment 3 WebKit Review Bot 2011-01-11 12:27:05 PST 
http://trac.webkit.org/changeset/75525 might have broken Windows Release (Build) and Windows Debug (Build)
Comment 4 John Sullivan 2011-01-11 12:35:30 PST 
I believe the WebKit Review Bot is oh so very wrong. This patch only affected the contents of one method in one Mac-specific file, so it could not have broken the Windows build.