Bug 52229

Summary: Enforce READ_ONLY transactions in IndexedDB
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, hans, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch japhet: review+

Jeremy Orlow
Reported 2011-01-11 11:29:37 PST
Enforce READ_ONLY transactions in IndexedDB
Attachments
Patch (34.24 KB, patch)
2011-01-11 11:32 PST, Jeremy Orlow 		japhet: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2011-01-11 11:32:29 PST
Created attachment 78565 [details] Patch
Jeremy Orlow
Comment 2 2011-01-11 11:33:09 PST
Andrei/hans, please take a look. Nate, can you please do the official review?
Nate Chapin
Comment 3 2011-01-11 13:14:17 PST
Comment on attachment 78565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78565&action=review The tests have huge diffs for no visible reason, so I'm assuming the line endings changed. Are they right before or after this patch? > Source/WebCore/storage/IDBCursorBackendImpl.cpp:169 > > - // FIXME: Check that the transaction is READ_WRITE > - // if (m_transaction->mode() == IDBTransaction::READ_ONLY) { > - // FIXME: We must return READ_ONLY_ERR here. Fix this when we update IDBDatabaseException to match the spec. > - // ec = IDBDatabaseException::NOT_ALLOWED_ERR; > - // return; > - // } > + Looks like two lines of whitespace here.
Hans Wennborg
Comment 4 2011-01-12 02:06:07 PST
(In reply to comment #2) > Andrei/hans, please take a look. Looks good.
Jeremy Orlow
Comment 5 2011-01-12 02:40:57 PST
Committed r75596: <http://trac.webkit.org/changeset/75596>
Note You need to log in before you can comment on or make changes to this bug.