| Summary: | Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Podivilov
2011-01-11 08:44:21 PST
Created attachment 78534 [details]
Patch.
Comment on attachment 78534 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=78534&action=review > Source/WebCore/inspector/front-end/Breakpoint.js:90 > + function gotSourceLine(text) in WebKit didGet... naming style is used > Source/WebCore/inspector/front-end/Script.js:60 > +WebInspector.Script.findLineEndings = function(source) This should be declared in utilities.js, maybe on String.prototype > Source/WebCore/inspector/front-end/Script.js:82 > + findLineEndings: function(callback) this method should be private > Source/WebCore/inspector/front-end/Script.js:123 > + function gotScriptSource(source) in WebKit didGet... naming style is used > Source/WebCore/inspector/front-end/Script.js:127 > + for (var i = 0; i < this.startingLine - 1; ++i) why do you need this? > Source/WebCore/inspector/front-end/Script.js:131 looks like you need to add this message to localizedStrings.js Created attachment 78925 [details]
Comments addressed.
Committed r75795: <http://trac.webkit.org/changeset/75795> |