Summary: | Align import/export directives in WebKit2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric, sam, s.mathur | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Laszlo Gombos
2011-01-11 06:30:03 PST
Created attachment 78523 [details]
proposed patch
Another option would be to have a shared header file under wtf to make sure these rules are aligned.
I'm not sure your #define indent matches webkit style. Created attachment 78940 [details]
Remove indentation
Comment on attachment 78940 [details] Remove indentation Rejecting attachment 78940 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2 Last 500 characters of output: ................................ fast/images/load-img-with-empty-src.html -> timed out Sampling process 18778 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 18778 written to file /Users/chrome-bot/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 8872 tests run. 258.75s total testing time 8871 test cases (99%) succeeded 1 test case (<1%) timed out 6 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7557041 The commit-queue encountered the following flaky tests while processing attachment 78940 [details]: http/tests/media/video-load-twice.html bug 51304 (authors: eric.carlson@apple.com and hclam@google.com) The commit-queue is continuing to process your patch. Comment on attachment 78940 [details]
Remove indentation
Try again...
Comment on attachment 78940 [details] Remove indentation Clearing flags on attachment: 78940 Committed r75806: <http://trac.webkit.org/changeset/75806> All reviewed patches have been landed. Closing bug. |