Bug 52175

Summary: Use a pull model for view state changes
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2011-01-10 15:54:17 PST
Use a pull model for view state changes
Attachments
Patch (27.20 KB, patch)
2011-01-10 15:58 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-10 15:58:39 PST
Created attachment 78465 [details] Patch
mitz
Comment 2 2011-01-10 16:04:40 PST
Comment on attachment 78465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78465&action=review > WebKit2/UIProcess/WebPageProxy.h:176 > + enum ViewStateFlags { > + IsViewWindowActive = 1 << 0, > + IsViewFocused = 1 << 1, > + IsViewVisible = 1 << 2, > + IsViewInWindow = 1 << 3 > + }; It’s not good that the value names read like questions. > WebKit2/UIProcess/WebPageProxy.h:177 > + void viewStateDidChange(unsigned flags); It would be better to have a typedef for this instead of using unsigned.
Sam Weinig
Comment 3 2011-01-10 16:40:34 PST
Comment on attachment 78465 [details] Patch r=me, though please consider making the changes mitz advised.
Anders Carlsson
Comment 4 2011-01-10 16:47:23 PST
Committed r75452: <http://trac.webkit.org/changeset/75452>
Note You need to log in before you can comment on or make changes to this bug.