Bug 52152 – Chromium DevTools: get rid of APU-related code in WebKit/chromium

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

APU should pretend to be an alternate devtools front-end.

[Pavel Feldman]

Created attachment 78405 [details]
[PATCH] Proposed change.

[James Robinson]

Are the changes under WebCore/ meant to be part of this patch?

[Pavel Feldman]

(In reply to comment #2)
> Are the changes under WebCore/ meant to be part of this patch?

Yes. This is a drive-by. Frontend reuse code went to WebCore (and now can be used both by Chromium port and WebKit2). It just became obvious that it belongs there while I was getting rid of APU.

[Yury Semikhatsky]

Comment on attachment 78405 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=78405&action=review

> Source/WebCore/inspector/InspectorController.cpp:-503
> -void InspectorController::reuseFrontend()

Please remove this from the header as well.

> WebKit/chromium/src/WebDevToolsAgentImpl.cpp:-402
> -        m_client->sendDispatchToAPU(message);

sendDispatchToAPU should go away

[Pavel Feldman]

Comment on attachment 78405 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 78405

Committed r75486: <http://trac.webkit.org/changeset/75486>

[Pavel Feldman]

All reviewed patches have been landed.  Closing bug.