| Summary: | [GTK] Filenames are converted to URLs during edit drags | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | Keywords: | Gtk | ||||
| Priority: | P3 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Bug Depends on: | 40833 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Martin Robinson
2011-01-07 18:02:30 PST
Created attachment 78298 [details]
Patch
Comment on attachment 78298 [details]
Patch
I'm confused by what you're doing for local files. Is this tested?
(In reply to comment #2) > (From update of attachment 78298 [details]) > I'm confused by what you're doing for local files. Is this tested? Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped). This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch. (In reply to comment #2) > (From update of attachment 78298 [details]) > I'm confused by what you're doing for local files. Is this tested? Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped). This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch. Comment on attachment 78298 [details]
Patch
OK.
Committed r76039: <http://trac.webkit.org/changeset/76039> |