Bug 52096 – [GTK] Filenames are converted to URLs during edit drags

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Martin Robinson]

This is a companion fix to https://bugs.webkit.org/show_bug.cgi?id=38826. It can be observed by the failure of editing/pasteboard/file-drag-to-editable.html.

[Martin Robinson]

Created attachment 78298 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 78298 [details]
Patch

I'm confused by what you're doing for local files.  Is this tested?

[Martin Robinson]

(In reply to comment #2)
> (From update of attachment 78298 [details])
> I'm confused by what you're doing for local files.  Is this tested?

Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped).

This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch.

[Martin Robinson]

(In reply to comment #2)
> (From update of attachment 78298 [details])
> I'm confused by what you're doing for local files.  Is this tested?

Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped).

This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch.

[Eric Seidel (no email)]

Comment on attachment 78298 [details]
Patch

OK.

[Martin Robinson]

Committed r76039: <http://trac.webkit.org/changeset/76039>