Bug 52087

Summary: Move all SVG renderer to WebCore/rendering/svg
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews, zherczeg, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dirk Schulze
Reported 2011-01-07 15:18:48 PST
Move all SVG renderer to WebCore/rendering/svg
Attachments
Patch (862.57 KB, patch)
2011-01-07 15:25 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (873.46 KB, patch)
2011-01-09 00:15 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (874.18 KB, patch)
2011-01-09 02:52 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2011-01-07 15:25:55 PST
Created attachment 78283 [details] Patch
Dirk Schulze
Comment 2 2011-01-07 15:27:21 PST
Please don't review the patch above. Just testing the build. Will clear the review flag when all build bots are ready.
Dirk Schulze
Comment 3 2011-01-07 15:45:34 PST
Comment on attachment 78283 [details] Patch Hm. I'll try to clean up the code according to the webkit style and try uploading this patch later, when less changes occur to the build systems. When ever this will be :-/
Zoltan Herczeg
Comment 4 2011-01-07 22:56:28 PST
Why? Is this a new policy?
Dirk Schulze
Comment 5 2011-01-07 23:00:51 PST
(In reply to comment #4) > Why? Is this a new policy? Talked on webkit-dev about it. I think it makes much more sense to move code to the type specific folders. I think even the renderer for mathml should move to rendering/mathml and if WML has renderers too, they should move to rendering/wml. Makes the structure of rendering/ much more readable.
Dirk Schulze
Comment 6 2011-01-09 00:15:02 PST
Created attachment 78343 [details] Patch
Early Warning System Bot
Comment 7 2011-01-09 01:25:20 PST
Attachment 78343 [details] did not build on qt: Build output: http://queues.webkit.org/results/7371076
Dirk Schulze
Comment 8 2011-01-09 02:52:47 PST
Created attachment 78348 [details] Patch
Dirk Schulze
Comment 9 2011-01-09 04:12:08 PST
It looks like the EWS bots are not sync to trunk. The patch applies and builds with trunk. Checked it locally.
Nikolas Zimmermann
Comment 10 2011-01-09 04:15:55 PST
Comment on attachment 78348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78348&action=review r=me. > Source/WebCore/GNUmakefile.am:2922 > + Source/WebCore/rendering/svg/RenderForeignObject.cpp \ > + Source/WebCore/rendering/svg/RenderForeignObject.h \ This should be renamed RenderSVGForeignObject, do you plan to do this in a follow-up patch?
Dirk Schulze
Comment 11 2011-01-09 04:18:49 PST
(In reply to comment #10) > (From update of attachment 78348 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78348&action=review > > r=me. > > > Source/WebCore/GNUmakefile.am:2922 > > + Source/WebCore/rendering/svg/RenderForeignObject.cpp \ > > + Source/WebCore/rendering/svg/RenderForeignObject.h \ > > This should be renamed RenderSVGForeignObject, do you plan to do this in a follow-up patch? Yes, I'll prepare a follow-up for review. Thanks.
Dirk Schulze
Comment 12 2011-01-09 04:36:00 PST
Comment on attachment 78348 [details] Patch Clearing flags on attachment: 78348 Committed r75350: <http://trac.webkit.org/changeset/75350>
Dirk Schulze
Comment 13 2011-01-09 04:36:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.