Bug 52086

Summary: Make WebKitTestRunner rest between loads more robust to avoid test crashes
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Description Maciej Stachowiak 2011-01-07 15:05:28 PST 
Make WebKitTestRunner rest between loads more robust to avoid test crashes
Comment 1 Maciej Stachowiak 2011-01-07 15:07:02 PST 
Created attachment 78278 [details]
Patch
Comment 2 Sam Weinig 2011-01-07 15:50:33 PST 
Comment on attachment 78278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78278&action=review

If you remove the debug code, this looks fine.  r=me

> Tools/WebKitTestRunner/TestController.cpp:40
> -static const double defaultShortTimeout = 5;
> +static const double defaultShortTimeout = 30;

You should revert this.

> Tools/WebKitTestRunner/TestController.cpp:364
> +    platformRunUntil(done, timeoutDuration == (TimeoutDuration)(-15) ? 3600 : timeoutDuration == ShortTimeout ? m_shortTimeout : m_longTimeout);

This too.

> Tools/WebKitTestRunner/TestInvocation.cpp:135
> +    TestController::shared().runUntil(m_gotFinalMessage, (TestController::TimeoutDuration)(-13));

Here too.
Comment 3 Maciej Stachowiak 2011-01-07 16:22:00 PST 
Committed r75291: <http://trac.webkit.org/changeset/75291>