| Summary: | [chromium] Layout test fast/events/overflow-events.html is flaky | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Stephen White <senorblanco> | ||||||
| Component: | DOM | Assignee: | Julien Chaffraix <jchaffraix> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bulach, jchaffraix, pkasting, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Stephen White
2011-01-07 08:39:58 PST
Now also flaky on Mac and Linux debug. Created attachment 129795 [details]
Proposed unflakynessing try.
Comment on attachment 129795 [details] Proposed unflakynessing try. View in context: https://bugs.webkit.org/attachment.cgi?id=129795&action=review > LayoutTests/fast/events/overflow-events.html:38 > + if (currentTest == testResults.length - 1) { > + finished("SUCCESS"); > + return; > + } Since this comes before verification of the test results, won't it skip verification of the last test? Comment on attachment 129795 [details] Proposed unflakynessing try. View in context: https://bugs.webkit.org/attachment.cgi?id=129795&action=review >> LayoutTests/fast/events/overflow-events.html:38 >> + } > > Since this comes before verification of the test results, won't it skip verification of the last test? I think you are right, let me tweak that so it's less error-prone. Created attachment 129908 [details]
Better unflakynessing.
Comment on attachment 129908 [details] Better unflakynessing. Clearing flags on attachment: 129908 Committed r109595: <http://trac.webkit.org/changeset/109595> All reviewed patches have been landed. Closing bug. The test is not flaky anymore so I removed the entry in http://trac.webkit.org/changeset/120225 |