Bug 52062

Summary: [chromium] Layout test fast/frames/iframe-reparenting-plugins.html is failing on windows
Product: WebKit Reporter: Stephen White <senorblanco>
Component: Layout and RenderingAssignee: Jenn Braithwaite <jennb>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, jennb, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
real patch ;-)
dimich: review+, dimich: commit-queue-
patch
dimich: review+, dimich: commit-queue-
patch none

Stephen White
Reported 2011-01-07 08:21:52 PST
Layout test fast/frames/iframe-reparenting-plugins.html introduced at r75169 is failing on chrome windows: This test verifies that plugin and mimetype in an iframe that is reparented to a different page continue to behave correctly. Loaded window 2. FAIL: Failed to find test plugin Adopted iframe to first page. Window 2 unloaded. FAIL: Failed to find test plugin
Attachments
patch (716 bytes, patch)
2011-01-10 15:08 PST, Jenn Braithwaite 		no flags
DetailsFormatted DiffDiff
real patch ;-) (1.33 KB, patch)
2011-01-10 15:14 PST, Jenn Braithwaite 		dimich: review+
dimich: commit-queue-
DetailsFormatted DiffDiff
patch (2.03 KB, patch)
2011-01-10 15:25 PST, Jenn Braithwaite 		dimich: review+
dimich: commit-queue-
DetailsFormatted DiffDiff
patch (1.43 KB, patch)
2011-01-20 17:32 PST, Jenn Braithwaite 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jenn Braithwaite
Comment 1 2011-01-10 15:08:56 PST
Created attachment 78455 [details] patch
Jenn Braithwaite
Comment 2 2011-01-10 15:14:11 PST
Created attachment 78457 [details] real patch ;-) Forgot ChangeLog earlier. Oops.
Dmitry Titov
Comment 3 2011-01-10 15:17:19 PST
Comment on attachment 78457 [details] real patch ;-) Will land it manually.
Jenn Braithwaite
Comment 4 2011-01-10 15:25:27 PST
Created attachment 78459 [details] patch Moved previous change disabling the test into the BUG_TONY grouping higher in the file.
Dmitry Titov
Comment 5 2011-01-10 15:26:47 PST
Comment on attachment 78459 [details] patch r=me
Dmitry Titov
Comment 6 2011-01-10 15:32:51 PST
Landed: http://trac.webkit.org/changeset/75442
Jenn Braithwaite
Comment 7 2011-01-20 17:32:39 PST
Created attachment 79672 [details] patch Test is now passing on Windows. Removing test from test_expectations.txt.
Dmitry Titov
Comment 8 2011-01-20 17:39:24 PST
Comment on attachment 79672 [details] patch r=me. I'll land it.
Dmitry Titov
Comment 9 2011-01-20 17:44:40 PST
Landed test_expectations update: http://trac.webkit.org/changeset/76317
Note You need to log in before you can comment on or make changes to this bug.