Bug 52054

Summary: [GTK] Port progressbar painting to GtkStyleContext
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 50820    
Attachments:
Description Flags
Use GtkStyleContext API to paint progressbars none

Description Carlos Garcia Campos 2011-01-07 05:23:58 PST 
Use GtkStyleContext api to paint progressbarsd when using gtk3
Comment 1 Carlos Garcia Campos 2011-01-07 05:32:08 PST 
Created attachment 78224 [details]
Use GtkStyleContext API to paint progressbars
Comment 2 Martin Robinson 2011-01-08 12:43:03 PST 
Comment on attachment 78224 [details]
Use GtkStyleContext API to paint progressbars

View in context: https://bugs.webkit.org/attachment.cgi?id=78224&action=review

Looks great, but please see below before landing this.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:369
> +static const int progressActivityBlocks = 5;
> +static const int progressAnimationFrames = 10;
> +static const double progressAnimationInterval = 0.125;

Include a comment before these values which explains where they originate from.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:411
> +        double progress = renderProgress->animationProgress();

I think this should be called animationProgress, to avoid confusing it with the actual progress position. Please just rename before landing. Thanks!
Comment 3 Carlos Garcia Campos 2011-01-10 01:10:18 PST 
Committed r75364: <http://trac.webkit.org/changeset/75364>