Bug 52031

Summary: [WIN] Add ProxyServerWin.cpp
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 52109    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2011-01-06 15:24:59 PST
see patch
Attachments
Patch (3.42 KB, patch)
2011-01-06 15:30 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-01-06 15:30:33 PST
Created attachment 78177 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-06 23:12:07 PST
Comment on attachment 78177 [details] Patch OK. Does the CPP file need to be wrapped in #if ENABLE()?
Patrick R. Gansterer
Comment 3 2011-01-07 01:30:45 PST
(In reply to comment #2) > (From update of attachment 78177 [details]) > OK. Does the CPP file need to be wrapped in #if ENABLE()? No. It will be used (linked) only when the NSAPI is enabled, otherwise they will be ignored while linking.
Laszlo Gombos
Comment 4 2011-01-10 08:45:25 PST
Comment on attachment 78177 [details] Patch LGTM, r+. ResourceHandleWin.cpp seems to be a similar case; no guard as it is only picked up by WinCE build system. I would still prefer to have some indication in the cpp files that these are at the moment only for WinCE (e.g. OS(x) guard), but it seems that this should be done for some other files as well, so perhaps it should be a separate patch.
WebKit Commit Bot
Comment 5 2011-01-10 10:14:19 PST
Comment on attachment 78177 [details] Patch Clearing flags on attachment: 78177 Committed r75383: <http://trac.webkit.org/changeset/75383>
WebKit Commit Bot
Comment 6 2011-01-10 10:14:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.