Bug 52020

Summary:

Member variables do not begin with m_ in QPageClientWidgetQt and QPageClientGraphicsWidgetQt

Product:

WebKit

Reporter:

Carol Szabo <carol>

Component:

WebKit Qt

Assignee:

Carol Szabo <carol>

Status:

RESOLVED INVALID

Severity:

Trivial

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

49184

Attachments:

Description	Flags
Proposed Patch	kling: review-

Description Carol Szabo 2011-01-06 14:44:59 PST

Naming a member variable "view" is not correct according to the WebKit style guidelines. Furthermore makes it difficult to distinguish such a member from an argument named "view".

Comment 1 Carol Szabo 2011-01-06 15:26:49 PST

Created attachment 78176 [details]
Proposed Patch

Comment 2 Andreas Kling 2011-01-07 03:58:24 PST

Comment on attachment 78176 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78176&action=review

The general rule is that public member variables don't have an "m_" prefix.
You could make them private and add setters/getters as needed.

> WebKit/qt/WebCoreSupport/PageClientQt.h:58
> -        : view(newView)
> -        , page(newPage)
> +        : m_view(newView)
> +        , m_page(newPage)
>  #if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER)
>          , syncTimer(this, &PageClientQWidget::syncLayers)
>          , platformLayerProxy(0)
>  #endif

Looks like you missed 'syncTimer' and 'platformLayerProxy'.