Bug 51971

Summary:

change the way we do comment highlighting in the code review tool

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Ojan Vafai 2011-01-05 17:14:59 PST

change the way we do comment highlighting in the code review tool

Comment 1 Ojan Vafai 2011-01-05 17:16:12 PST

Created attachment 78077 [details]
Patch

Comment 2 Adam Barth 2011-01-05 17:43:18 PST

Comment on attachment 78077 [details]
Patch

Interesting idea.  I'll be interested to see how this works in side-by-side mode.

I feel like you're teaching me JavaScript in these patches, which I appreciate.  :)

Comment 3 WebKit Commit Bot 2011-01-05 20:37:11 PST

Comment on attachment 78077 [details]
Patch

Clearing flags on attachment: 78077

Committed r75133: <http://trac.webkit.org/changeset/75133>

Comment 4 WebKit Commit Bot 2011-01-05 20:37:17 PST

All reviewed patches have been landed.  Closing bug.