Bug 51971

Summary: change the way we do comment highlighting in the code review tool
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Ojan Vafai
Reported 2011-01-05 17:14:59 PST
change the way we do comment highlighting in the code review tool
Attachments
Patch (5.02 KB, patch)
2011-01-05 17:16 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-01-05 17:16:12 PST
Created attachment 78077 [details] Patch
Adam Barth
Comment 2 2011-01-05 17:43:18 PST
Comment on attachment 78077 [details] Patch Interesting idea. I'll be interested to see how this works in side-by-side mode. I feel like you're teaching me JavaScript in these patches, which I appreciate. :)
WebKit Commit Bot
Comment 3 2011-01-05 20:37:11 PST
Comment on attachment 78077 [details] Patch Clearing flags on attachment: 78077 Committed r75133: <http://trac.webkit.org/changeset/75133>
WebKit Commit Bot
Comment 4 2011-01-05 20:37:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.