Bug 51971 - change the way we do comment highlighting in the code review tool
Summary: change the way we do comment highlighting in the code review tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-05 17:14 PST by Ojan Vafai
Modified: 2011-01-05 20:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2011-01-05 17:16 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-01-05 17:14:59 PST 
change the way we do comment highlighting in the code review tool
Comment 1 Ojan Vafai 2011-01-05 17:16:12 PST 
Created attachment 78077 [details]
Patch
Comment 2 Adam Barth 2011-01-05 17:43:18 PST 
Comment on attachment 78077 [details]
Patch

Interesting idea.  I'll be interested to see how this works in side-by-side mode.

I feel like you're teaching me JavaScript in these patches, which I appreciate.  :)
Comment 3 WebKit Commit Bot 2011-01-05 20:37:11 PST 
Comment on attachment 78077 [details]
Patch

Clearing flags on attachment: 78077

Committed r75133: <http://trac.webkit.org/changeset/75133>
Comment 4 WebKit Commit Bot 2011-01-05 20:37:17 PST 
All reviewed patches have been landed.  Closing bug.