Summary: | WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeff Miller <jeffm> | ||||||
Component: | WebKit2 | Assignee: | Jeff Miller <jeffm> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Jeff Miller
2011-01-05 16:25:39 PST
This is to support the equivalent of IWebFramePrivate::contentBounds() and IWebFramePrivate::scrollOffset from WebKit1. Created attachment 78061 [details]
Patch
Comment on attachment 78061 [details] Patch Obsoleting this patch, once https://bugs.webkit.org/show_bug.cgi?id=51970 lands I'll redo the patch to include the parameter names in the header. Created attachment 78095 [details]
Patch to add APIs to WKBundleFrame to get content bounds and scroll offset
Comment on attachment 78095 [details] Patch to add APIs to WKBundleFrame to get content bounds and scroll offset View in context: https://bugs.webkit.org/attachment.cgi?id=78095&action=review > WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:145 > + WKRect contentBounds = { {0, 0}, {0, 0} }; We’d normally put four more spaces in there. (In reply to comment #5) > (From update of attachment 78095 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78095&action=review > > > WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:145 > > + WKRect contentBounds = { {0, 0}, {0, 0} }; > > We’d normally put four more spaces in there. Normally, I prefer contentBounds = { 0 }, which avoids any dependency on the internal structure of WKRect, but Sam said he did it this way. Thanks for reviewing. Comment on attachment 78095 [details] Patch to add APIs to WKBundleFrame to get content bounds and scroll offset Clearing flags on attachment: 78095 Committed r75171: <http://trac.webkit.org/changeset/75171> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/75171 might have broken GTK Linux 32-bit Release |