Bug 51943

Summary:

Implement word transformation

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	sam: review+

Description Anders Carlsson 2011-01-05 12:12:37 PST

Implement word transformation

Comment 1 Anders Carlsson 2011-01-05 12:16:13 PST

Created attachment 78025 [details]
Patch

Comment 2 Anders Carlsson 2011-01-05 12:19:13 PST

Committed r75093: <http://trac.webkit.org/changeset/75093>

Comment 3 Anders Carlsson 2011-01-05 12:50:57 PST

Created attachment 78029 [details]
Patch

Comment 4 Sam Weinig 2011-01-05 13:19:11 PST

Comment on attachment 78029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78029&action=review

> WebKit2/UIProcess/mac/TextCheckerMac.mm:176
> +    static bool readSmartInsertDeleteEnabledDefault = false;

= false not necessary.  Can't you just do:

static bool smartInsertDeleteEnabled = [[NSUserDefaults standardUserDefaults] boolForKey:WebSmartInsertDeleteEnabled];
return smartInsertDeleteEnabled;

> WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:73
> +    // FIXME: Why isn't this Mac specific like toggleSmartInsertDeleteEnabled?

I think we enable it on Windows all the time, but some ports want to turn it off.

Comment 5 Anders Carlsson 2011-01-05 13:22:11 PST

Committed r75098: <http://trac.webkit.org/changeset/75098>

Comment 6 Eric Seidel (no email) 2011-01-05 14:06:48 PST

I believe this broke the build.