Bug 51938

Summary: check-webkit-style should not suggest removing argument names in WebKit2 API files
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: andersca, levin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2011-01-05 11:19:13 PST
E.g. https://bugs.webkit.org/show_bug.cgi?id=51935#c2 These are C headers, so argument names are not optional.
Attachments
Patch (1.55 KB, patch)
2011-01-05 12:02 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-01-05 11:44:27 PST
I was wrong - argument names are not necessary in function declarations even in plain C. So, it's a style choice for WebKit2 API headers - perhaps check-webkit-style should warn if arguments are missing. Sam, Anders, can you confirm?
David Levin
Comment 2 2011-01-05 12:02:25 PST
Created attachment 78024 [details] Patch
David Levin
Comment 3 2011-01-05 12:04:38 PST
(In reply to comment #1) > perhaps check-webkit-style should warn if arguments are missing. Feel free to file a bug if you think this is a common issue that is worth adding a check for. Since I'm messing around in this area right now, I will probably tackle it soon-ish. (If this issue is pretty rare, feel free to not add a bug so I don't spend time on it :).)
David Levin
Comment 4 2011-01-05 18:22:39 PST
Resolved as dup since the other bug with the fix has an r+ now :). *** This bug has been marked as a duplicate of bug 51970 ***
Note You need to log in before you can comment on or make changes to this bug.