Bug 51935

Summary: Add WebKit2 API for largest frame
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch andersca: review+

Alexey Proskuryakov
Reported 2011-01-05 11:04:03 PST
Forgot to publish the new accessor as WK2 API.
Attachments
proposed patch (1.74 KB, patch)
2011-01-05 11:05 PST, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-01-05 11:05:16 PST
Created attachment 78018 [details] proposed patch
WebKit Review Bot
Comment 2 2011-01-05 11:06:47 PST
Attachment 78018 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/C/WKPage.cpp', u'WebKit2/UIProcess/API/C/WKPage.h']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:271: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2011-01-05 11:19:37 PST
Filed 51938 against check-webkit-style.
Alexey Proskuryakov
Comment 4 2011-01-05 11:49:20 PST
Committed <http://trac.webkit.org/changeset/75089>.
Note You need to log in before you can comment on or make changes to this bug.