Summary: | [Qt] [WK2] Add support for non-trivial context menu action | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, kenneth | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 51825 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Benjamin Poulain
2011-01-04 15:19:47 PST
(In reply to comment #0) > The patch https://bugs.webkit.org/show_bug.cgi?id=51825 added support for the context menu. Now it is time to use it to peform something useful :) You don't seem to like the letter r in the beginning of words: peform and suppot ;-) Let me fix the title! Created attachment 77937 [details]
Patch
Created attachment 77939 [details]
Patch
I did not mean to remove that blank line.
(In reply to comment #1) > You don't seem to like the letter r in the beginning of words: peform and suppot ;-) Let me fix the title! Thanks for fixing the the title. I guess there is too much food in my keyboard for it to work properly ;) Comment on attachment 77939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77939&action=review Looks good > WebKit2/UIProcess/API/qt/qwkpage.cpp:604 > + QAction* qtAction = action(webAction); So this action() converter was already defined? (In reply to comment #5) > > WebKit2/UIProcess/API/qt/qwkpage.cpp:604 > > + QAction* qtAction = action(webAction); > > So this action() converter was already defined? Yep, QWKPage::action() seem to be a copy of the design of QWebPage::action(). It is used to get the page action in any context. Thanks for the review Kenneth. Comment on attachment 77939 [details] Patch Clearing flags on attachment: 77939 Committed r75047: <http://trac.webkit.org/changeset/75047> All reviewed patches have been landed. Closing bug. |