| Summary: | Send over text checker state to the web process | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, buildbot, eric, webkit-ews, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2011-01-04 14:08:17 PST
Created attachment 77932 [details]
Patch
Comment on attachment 77932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77932&action=review Do you need to update WebKit2.pro? r=me if you fix these issues. > WebKit2/UIProcess/mac/TextCheckerMac.mm:36 > +TextCheckerState textCheckerState; Will this cause a static constructor to be called? > WebKit2/UIProcess/mac/TextCheckerMac.mm:39 > +static void initializeState() { > + static bool didInitializeState = false; { on the wrong line. I believe the = false is unnecessary. Comment on attachment 77932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77932&action=review > WebKit2/UIProcess/mac/TextCheckerMac.mm:32 > +#define WebAutomaticSpellingCorrectionEnabled @"WebAutomaticSpellingCorrectionEnabled" > +#define WebContinuousSpellCheckingEnabled @"WebContinuousSpellCheckingEnabled" > +#define WebGrammarCheckingEnabled @"WebGrammarCheckingEnabled" Are macros really necessary? Could we do this another way? Committed r75010: <http://trac.webkit.org/changeset/75010> http://trac.webkit.org/changeset/75010 might have broken Qt Linux Release Attachment 77932 [details] did not build on qt: Build output: http://queues.webkit.org/results/7216409 Attachment 77932 [details] did not build on win: Build output: http://queues.webkit.org/results/7237406 |