Bug 51887

Summary: [GTK] Use the default CSS text input control border width of relying on the GTK+ theme
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2011-01-04 12:16:45 PST
GTK+ themes generally have text control border widths between 1 and 3 pixels. The html.css border widths (2 pixels for text input controls and 1 pixel for text area controls) seem to produce rendering results that are fine for every theme I've tested. Removing this variation between GTK+ themes will: 1. Remove some code. 2. Ensure consistent DRT results between GTK 2.x and GTK 3.x. 3. Protect the DRT results from future theme changes. The current default GTK 2.x theme has a border width of 2 pixels, so this change should only require updating results that have text areas.
Attachments
Patch (144.04 KB, patch)
2011-01-04 13:42 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-01-04 13:42:06 PST
Created attachment 77925 [details] Patch
Xan Lopez
Comment 2 2011-01-04 14:13:19 PST
Comment on attachment 77925 [details] Patch OK, let's do this.
Xan Lopez
Comment 3 2011-01-04 14:13:34 PST
Comment on attachment 77925 [details] Patch I was saying...
Martin Robinson
Comment 4 2011-01-04 14:58:55 PST
Comment on attachment 77925 [details] Patch Clearing flags on attachment: 77925 Committed r75016: <http://trac.webkit.org/changeset/75016>
Martin Robinson
Comment 5 2011-01-04 14:59:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.