Summary: | [GTK] WebKit2 GNUmakefile is out of date from trunk | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ravi Phaneendra Kasibhatla <ravi.kasibhatla> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | amruthraj, commit-queue, mrobinson | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 52805 | ||||||||
Attachments: |
|
Description
Ravi Phaneendra Kasibhatla
2011-01-04 10:44:13 PST
Tagging it as GTK port bug Created attachment 78230 [details]
GTK Stubbed Implementations on latest revision
Created attachment 78231 [details]
Makefile changes and signature changes on latest revision
Comment on attachment 78231 [details]
Makefile changes and signature changes on latest revision
Hopefully the commit-queue does the right thing with two patches here. :)
The commit-queue encountered the following flaky tests while processing attachment 78230 [details]: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 78230 [details] GTK Stubbed Implementations on latest revision Clearing flags on attachment: 78230 Committed r75272: <http://trac.webkit.org/changeset/75272> Comment on attachment 78231 [details] Makefile changes and signature changes on latest revision Rejecting attachment 78231 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 78231]" exit_code: 1 Last 500 characters of output: le "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/7451037 Committed r75345: <http://trac.webkit.org/changeset/75345> |