Bug 51883 – [GTK] WebKit2 GNUmakefile is out of date from trunk

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ravi Phaneendra Kasibhatla]

The WebKit2 GNUmakefile.am is out of date from the trunk. Some of the file path (given in makefile) are changed, while some of the files have been removed. The makefile needs to be updated for proper source file list as per latest trunk

[Ravi Phaneendra Kasibhatla]

Tagging it as GTK port bug

[Ravi Phaneendra Kasibhatla]

Created attachment 78230 [details]
GTK Stubbed Implementations on latest revision

[Ravi Phaneendra Kasibhatla]

Created attachment 78231 [details]
Makefile changes and signature changes on latest revision

[Martin Robinson]

Comment on attachment 78231 [details]
Makefile changes and signature changes on latest revision

Hopefully the commit-queue does the right thing with two patches here. :)

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 78230 [details]:

http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 78230 [details]
GTK Stubbed Implementations on latest revision

Clearing flags on attachment: 78230

Committed r75272: <http://trac.webkit.org/changeset/75272>

[WebKit Commit Bot]

Comment on attachment 78231 [details]
Makefile changes and signature changes on latest revision

Rejecting attachment 78231 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 78231]" exit_code: 1
Last 500 characters of output:
le "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Full output: http://queues.webkit.org/results/7451037

[Martin Robinson]

Committed r75345: <http://trac.webkit.org/changeset/75345>