Bug 51877

Summary: Web Inspector: [regression] Cookies view does not allow columns resize.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change none

Pavel Feldman
Reported 2011-01-04 09:36:01 PST
Patch to follow.
Attachments
[PATCH] Proposed change (1.12 KB, patch)
2011-01-04 09:37 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-04 09:37:28 PST
Created attachment 77895 [details] [PATCH] Proposed change
Joseph Pecoraro
Comment 2 2011-01-05 04:47:13 PST
Comment on attachment 77895 [details] [PATCH] Proposed change When did this regress?
Joseph Pecoraro
Comment 3 2011-01-05 05:16:26 PST
Comment on attachment 77895 [details] [PATCH] Proposed change All updates go through this function, so this might work on updates work, What problem is this fixing? Shouldn't the resize event on the datagrid already handle this? I see one defined on the simple cookie table, but not the advanced. I see the datagrid fires a "width changed" event on resize changes, that might be good to tap into. I'm in a car so I can't quite fully verify :(.
Pavel Feldman
Comment 4 2011-01-11 04:57:30 PST
> All updates go through this function, so this might work on updates work, What problem is this fixing? Shouldn't the resize event on the datagrid already handle this? I see one defined on the simple cookie table, but not the advanced. I see the datagrid fires a "width changed" event on resize changes, that might be good to tap into. I'm in a car so I can't quite fully verify :(. Ok, to repro: 1. pull up 2. stop engine 3. run webkit nightly 4. try resizing cookies table columns :)
WebKit Commit Bot
Comment 5 2011-01-11 05:18:02 PST
Comment on attachment 77895 [details] [PATCH] Proposed change Clearing flags on attachment: 77895 Committed r75489: <http://trac.webkit.org/changeset/75489>
WebKit Commit Bot
Comment 6 2011-01-11 05:18:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.