Summary: | [Qt] Default focus ring is too wide | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yael <yael> | ||||||||||
Component: | Accessibility | Assignee: | Alexis Menard (darktears) <menard> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, menard, ossy | ||||||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Bug Depends on: | 52612 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Yael
2011-01-03 16:33:29 PST
Created attachment 78036 [details]
Intermediate step: use QPalette::Highlight instead of black
Comment on attachment 78036 [details]
Intermediate step: use QPalette::Highlight instead of black
re=me
(In reply to comment #1) > Created an attachment (id=78036) [details] > Intermediate step: use QPalette::Highlight instead of black Thanks for doing this! I was looking for a QStyle API for color selection, and did not find any:( <https://bugs.webkit.org/show_bug.cgi?id=50325#c6> Comment on attachment 78036 [details] Intermediate step: use QPalette::Highlight instead of black Clearing flags on attachment: 78036 Committed r75126: <http://trac.webkit.org/changeset/75126> All reviewed patches have been landed. Closing bug. This was an intermediate fix. After https://bugs.webkit.org/show_bug.cgi?id=52612 is fixed, we could easily change the default width of the focus ring. Created attachment 82011 [details]
Patch to fix the ugly focus ring
This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option.
Comment on attachment 82011 [details]
Patch to fix the ugly focus ring
Needs ChangeLog. I agree with patch otherwise, our focus rings are way too ugly right now.
Created attachment 82012 [details]
Patch to fix the ugly focus ring
This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option.
Changelog for some weird reason was not in the diff.
Created attachment 82013 [details]
Patch to fix the ugly focus ring
This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option.
With ChangeLog
Comment on attachment 82013 [details]
Patch to fix the ugly focus ring
r=me
Comment on attachment 82013 [details] Patch to fix the ugly focus ring Clearing flags on attachment: 82013 Committed r78259: <http://trac.webkit.org/changeset/78259> All reviewed patches have been landed. Closing bug. |