Bug 51850

Summary: Put CFNetwork loader code inside USE(CFNETWORK)
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: Page LoadingAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, psolanki, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51836    
Attachments:
Description Flags
Patch darin: review+

Pratik Solanki
Reported 2011-01-03 13:39:28 PST
As part of fixing bug 51836, we need to put all CFNetwork files inside #if USE(CFNETWORK). Corresponding Mac code that uses Foundation should be put under #if !USE(CFNETWORK). Then we can add all the CFNetwork files to the WebCore xcode project.
Attachments
Patch (34.06 KB, patch)
2011-01-03 14:48 PST, Pratik Solanki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2011-01-03 14:48:51 PST
Created attachment 77848 [details] Patch
Pratik Solanki
Comment 2 2011-01-03 15:46:48 PST
Committed r74943 - <http://trac.webkit.org/changeset/74943>
WebKit Review Bot
Comment 3 2011-01-03 16:18:54 PST
http://trac.webkit.org/changeset/74943 might have broken Windows Release (Build) and Windows Debug (Build)
Pratik Solanki
Comment 4 2011-01-03 17:00:46 PST
Follow on commits to fix build breakage http://trac.webkit.org/changeset/74948 http://trac.webkit.org/changeset/74949
Note You need to log in before you can comment on or make changes to this bug.