Bug 51847

Summary: Shrink RootInlineBox
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Roll m_baselineType into a bitfield darin: review+

mitz
Reported 2011-01-03 13:17:59 PST
Shrink RootInlineBox
Attachments
Roll m_baselineType into a bitfield (1.04 KB, patch)
2011-01-03 13:20 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2011-01-03 13:20:20 PST
Created attachment 77839 [details] Roll m_baselineType into a bitfield
Darin Adler
Comment 2 2011-01-03 13:24:46 PST
Comment on attachment 77839 [details] Roll m_baselineType into a bitfield Did you test whether this works properly on Windows? I seem to recall that on Windows bitfields are signed so the 1 value ends up being -1. Sometimes we have to use the type unsigned instead of the actual enum type to work around that. r=m if this doesn't break with MSVC.
mitz
Comment 3 2011-01-03 13:42:00 PST
Committed r74937. <http://trac.webkit.org/projects/webkit/changeset/74937>
WebKit Review Bot
Comment 4 2011-01-03 14:10:37 PST
http://trac.webkit.org/changeset/74937 might have broken SnowLeopard Intel Release (Build)
Note You need to log in before you can comment on or make changes to this bug.