Bug 51847

Summary:

Shrink RootInlineBox

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Roll m_baselineType into a bitfield	darin: review+

Description mitz 2011-01-03 13:17:59 PST

Shrink RootInlineBox

Comment 1 mitz 2011-01-03 13:20:20 PST

Created attachment 77839 [details]
Roll m_baselineType into a bitfield

Comment 2 Darin Adler 2011-01-03 13:24:46 PST

Comment on attachment 77839 [details]
Roll m_baselineType into a bitfield

Did you test whether this works properly on Windows? I seem to recall that on Windows bitfields are signed so the 1 value ends up being -1. Sometimes we have to use the type unsigned instead of the actual enum type to work around that. r=m if this doesn't break with MSVC.

Comment 3 mitz 2011-01-03 13:42:00 PST

Committed r74937.
<http://trac.webkit.org/projects/webkit/changeset/74937>

Comment 4 WebKit Review Bot 2011-01-03 14:10:37 PST

http://trac.webkit.org/changeset/74937 might have broken SnowLeopard Intel Release (Build)