Bug 51776

Summary: Web Inspector: make properties on Array's prototype non-enumerable
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. none

Pavel Podivilov
Reported 2010-12-31 05:26:19 PST
Web Inspector: make properties on Array's prototype non-enumerable
Attachments
Patch. (1.47 KB, patch)
2010-12-31 05:27 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-12-31 05:27:23 PST
Created attachment 77717 [details] Patch.
Eric Seidel (no email)
Comment 2 2010-12-31 09:31:05 PST
Comment on attachment 77717 [details] Patch. How do we test this? What's the purpose of this change?
Pavel Feldman
Comment 3 2011-01-10 04:46:45 PST
(In reply to comment #2) > (From update of attachment 77717 [details]) > How do we test this? What's the purpose of this change? Hey. This is a trivial change to the inspector's utility Array extension. It just makes functions on array prototype non-enumerable. It does not affect web-facing functionality. I would test it using jsunit or similar in inspector context, but we don't have such harness yet.
WebKit Commit Bot
Comment 4 2011-01-10 06:38:30 PST
The commit-queue encountered the following flaky tests while processing attachment 77717 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-01-10 06:39:59 PST
Comment on attachment 77717 [details] Patch. Clearing flags on attachment: 77717 Committed r75370: <http://trac.webkit.org/changeset/75370>
WebKit Commit Bot
Comment 6 2011-01-10 06:40:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.