Bug 51768

Summary: Move V8 to WebCore Location implementation
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: antonm, commit-queue, darin, dglazkov, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-12-31 00:48:11 PST
Move V8 to WebCore Location implementation
Attachments
Patch (16.83 KB, patch)
2010-12-31 00:49 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (16.83 KB, patch)
2010-12-31 00:59 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-12-31 00:49:54 PST
Created attachment 77706 [details] Patch
Adam Barth
Comment 2 2010-12-31 00:59:43 PST
Created attachment 77707 [details] Patch
WebKit Review Bot
Comment 3 2010-12-31 01:04:25 PST
Attachment 77706 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7324275
anton muhin
Comment 4 2010-12-31 01:24:53 PST
LGTM and thanks (In reply to comment #3) > Attachment 77706 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/7324275
WebKit Review Bot
Comment 5 2010-12-31 02:11:33 PST
Attachment 77706 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7305283
Eric Seidel (no email)
Comment 6 2010-12-31 09:09:49 PST
Comment on attachment 77707 [details] Patch LGTM. Are there any testable functional changes from thsi?
Darin Adler
Comment 7 2010-12-31 11:37:09 PST
(In reply to comment #6) > Are there any testable functional changes from thsi? Our intention is that there not be any changes. This is a refactoring to move code out of JavaScript bindings into the DOM where it belongs.
WebKit Commit Bot
Comment 8 2010-12-31 11:56:45 PST
Comment on attachment 77707 [details] Patch Clearing flags on attachment: 77707 Committed r74833: <http://trac.webkit.org/changeset/74833>
WebKit Commit Bot
Comment 9 2010-12-31 11:56:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.