RESOLVED FIXED 51768
Move V8 to WebCore Location implementation 
https://bugs.webkit.org/show_bug.cgi?id=51768
Summary Move V8 to WebCore Location implementation
Adam Barth
Reported Friday, December 31, 2010 8:48:11 AM UTC
Move V8 to WebCore Location implementation
Attachments
Patch (16.83 KB, patch)
2010-12-31 00:49 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (16.83 KB, patch)
2010-12-31 00:59 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 Friday, December 31, 2010 8:49:54 AM UTC
Created attachment 77706 [details] Patch
Adam Barth
Comment 2 Friday, December 31, 2010 8:59:43 AM UTC
Created attachment 77707 [details] Patch
WebKit Review Bot
Comment 3 Friday, December 31, 2010 9:04:25 AM UTC
Attachment 77706 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7324275
anton muhin
Comment 4 Friday, December 31, 2010 9:24:53 AM UTC
LGTM and thanks (In reply to comment #3) > Attachment 77706 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/7324275
WebKit Review Bot
Comment 5 Friday, December 31, 2010 10:11:33 AM UTC
Attachment 77706 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7305283
Eric Seidel (no email)
Comment 6 Friday, December 31, 2010 5:09:49 PM UTC
Comment on attachment 77707 [details] Patch LGTM. Are there any testable functional changes from thsi?
Darin Adler
Comment 7 Friday, December 31, 2010 7:37:09 PM UTC
(In reply to comment #6) > Are there any testable functional changes from thsi? Our intention is that there not be any changes. This is a refactoring to move code out of JavaScript bindings into the DOM where it belongs.
WebKit Commit Bot
Comment 8 Friday, December 31, 2010 7:56:45 PM UTC
Comment on attachment 77707 [details] Patch Clearing flags on attachment: 77707 Committed r74833: <http://trac.webkit.org/changeset/74833>
WebKit Commit Bot
Comment 9 Friday, December 31, 2010 7:56:52 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.