Bug 51768 - Move V8 to WebCore Location implementation
Summary: Move V8 to WebCore Location implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-31 00:48 PST by Adam Barth
Modified: 2010-12-31 11:56 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.83 KB, patch)
2010-12-31 00:49 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (16.83 KB, patch)
2010-12-31 00:59 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-12-31 00:48:11 PST 
Move V8 to WebCore Location implementation
Comment 1 Adam Barth 2010-12-31 00:49:54 PST 
Created attachment 77706 [details]
Patch
Comment 2 Adam Barth 2010-12-31 00:59:43 PST 
Created attachment 77707 [details]
Patch
Comment 3 WebKit Review Bot 2010-12-31 01:04:25 PST 
Attachment 77706 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7324275
Comment 4 anton muhin 2010-12-31 01:24:53 PST 
LGTM and thanks

(In reply to comment #3)
> Attachment 77706 [details] did not build on chromium:
> Build output: http://queues.webkit.org/results/7324275
Comment 5 WebKit Review Bot 2010-12-31 02:11:33 PST 
Attachment 77706 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7305283
Comment 6 Eric Seidel (no email) 2010-12-31 09:09:49 PST 
Comment on attachment 77707 [details]
Patch

LGTM.  Are there any testable functional changes from thsi?
Comment 7 Darin Adler 2010-12-31 11:37:09 PST 
(In reply to comment #6)
> Are there any testable functional changes from thsi?

Our intention is that there not be any changes. This is a refactoring to move code out of JavaScript bindings into the DOM where it belongs.
Comment 8 WebKit Commit Bot 2010-12-31 11:56:45 PST 
Comment on attachment 77707 [details]
Patch

Clearing flags on attachment: 77707

Committed r74833: <http://trac.webkit.org/changeset/74833>
Comment 9 WebKit Commit Bot 2010-12-31 11:56:52 PST 
All reviewed patches have been landed.  Closing bug.