Bug 51756

Summary:

CMAKE doesn't build plugins/PluginDataNone.cpp when ENABLE_NETSCAPE_PLUGIN_API is OFF

Product:

WebKit

Reporter:

Benjamin Meyer <ben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

paroga

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed solution	none
Same as before, but with a populated ChangeLog file	darin: review+

Description Benjamin Meyer 2010-12-30 11:25:55 PST

When ENABLE_NETSCAPE_PLUGIN_API is OFF the cmake build system was not including plugins/PluginDataNone.cpp which goes with plugins/PluginPackageNone.cpp and plugins/PluginViewNone.cpp.

Comment 1 Benjamin Meyer 2010-12-30 11:29:01 PST

Created attachment 77690 [details]
proposed solution

Comment 2 Benjamin Meyer 2010-12-30 11:31:09 PST

Created attachment 77692 [details]
Same as before, but with a populated ChangeLog file

Comment 3 Patrick R. Gansterer 2010-12-30 12:43:29 PST

View in context: https://bugs.webkit.org/attachment.cgi?id=77692&action=review

> WebCore/CMakeLists.txt:1719
> +        plugins/PluginDataNone.cpp

r-: you need to add this in a port specific file (like EFL), becuase windows never uses PluginDataNone.
see http://trac.webkit.org/browser/trunk/WebCore/CMakeListsWinCE.txt#L116

Comment 4 Benjamin Meyer 2010-12-30 13:02:15 PST

Following Patrick's suggestion I have modified the port cmake file and am marking this as resolved.