Bug 51745

Summary:

Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch.	pfeldman: review+

Description Pavel Podivilov 2010-12-30 05:36:20 PST

Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.

Comment 1 Pavel Podivilov 2010-12-30 05:37:11 PST

Created attachment 77675 [details]
Patch.

Comment 2 Pavel Feldman 2010-12-30 05:59:07 PST

Comment on attachment 77675 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=77675&action=review

> WebCore/inspector/front-end/Breakpoint.js:55
> +        this.remove();

It would be great if breakpoint had two states: "resolved" and "unresolved". In that case, setting enabled to false would simply make it unresolved unless backend confirms disabling.

Comment 3 Pavel Podivilov 2010-12-30 07:33:32 PST

Committed r74798: <http://trac.webkit.org/changeset/74798>