Bug 51740

Summary: Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore JavaScriptAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benm, commit-queue, steveblock, swang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch none

Steve Block
Reported 2010-12-30 03:08:57 PST
Android does not enable either the Inspector or Debugger. It does however use rich source info (eg line numbers for exceptions) http://trac.webkit.org/changeset/72360 changed JSC to guard the exception-generation code behind enable flags. As a result, rich source info was disabled for Android. We should re-enable rich source info for Android. This can be done in JSDOMWindowBase::supportsRichSourceInfo(), which encapsulates such policy decisions.
Attachments
Patch (1.30 KB, patch)
2010-12-30 03:18 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-12-30 03:18:36 PST
Created attachment 77670 [details] Patch
WebKit Commit Bot
Comment 2 2010-12-30 12:53:46 PST
Comment on attachment 77670 [details] Patch Clearing flags on attachment: 77670 Committed r74806: <http://trac.webkit.org/changeset/74806>
WebKit Commit Bot
Comment 3 2010-12-30 12:53:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.