Bug 51739

Summary: [CMake] Fix the usage of SOURCE_GROUP
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43906    
Attachments:
Description Flags
Patch
kling: review+, commit-queue: commit-queue-
Patch none

Description Patrick R. Gansterer 2010-12-30 03:02:56 PST
see patch
Comment 1 Patrick R. Gansterer 2010-12-30 03:06:03 PST
Created attachment 77668 [details]
Patch
Comment 2 Andreas Kling 2011-01-05 06:39:52 PST
Comment on attachment 77668 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2011-01-05 06:41:14 PST
Comment on attachment 77668 [details]
Patch

Rejecting attachment 77668 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--no-update', '--non-interactive', 77668]" exit_code: 2
Last 500 characters of output:
--- Sources/cmake/WebKitMacros.cmake
|+++ Sources/cmake/WebKitMacros.cmake
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
patching file WebCore/CMakeLists.txt
Hunk #1 FAILED at 2215.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/CMakeLists.txt.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7210426
Comment 4 Patrick R. Gansterer 2011-01-05 06:46:46 PST
Created attachment 77999 [details]
Patch

Sources -> Source
Comment 5 WebKit Commit Bot 2011-01-05 06:52:32 PST
Comment on attachment 77999 [details]
Patch

Rejecting attachment 77999 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'apply-attachment', '--no-update', '--non-interactive', 77999]" exit_code: 2
Last 500 characters of output:
eded at 1 with fuzz 3.
patching file Source/JavaScriptCore/CMakeLists.txt
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/cmake/WebKitMacros.cmake
patching file WebCore/CMakeLists.txt
Hunk #1 FAILED at 2215.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/CMakeLists.txt.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7338329
Comment 6 Patrick R. Gansterer 2011-01-05 14:40:46 PST
Comment on attachment 77999 [details]
Patch

Clearing flags on attachment: 77999

Manually committed r75069: <http://trac.webkit.org/changeset/75069>
Comment 7 Patrick R. Gansterer 2011-01-05 14:41:07 PST
All reviewed patches have been landed.  Closing bug.