Summary: | [GTK] GSettings warning is concealing real warnings on the build bots | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||||
Priority: | P3 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Martin Robinson
2010-12-28 14:49:00 PST
Created attachment 77581 [details]
Patch for this issue
Comment on attachment 77581 [details]
Patch for this issue
OK. It's sad that that's the only way to disable the message. Is that string saved anywhere in Gtk that you could compare against a variable instead of a manually typed c-string?
Created attachment 77621 [details]
An alternate approach to this problem
(In reply to comment #3) > Created an attachment (id=77621) [details] > An alternate approach to this problem Here's another way to approach the issue. Instead of filtering the message in DumpRenderTree, this patch modifies WebKitGTK+ to not print the message when running in DumpRenderTree. Comment on attachment 77621 [details]
An alternate approach to this problem
I prefer this one by a long shot.
Comment on attachment 77621 [details] An alternate approach to this problem Clearing flags on attachment: 77621 Committed r74762: <http://trac.webkit.org/changeset/74762> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/74762 might have broken Leopard Intel Debug (Tests) |