Bug 51672

Summary:

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is used

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Fixed usage of USE_SYSTEM_MALLOC	eric: review+, commit-queue: commit-queue-
Fixed usage of USE_SYSTEM_MALLOC	none
Fixed usage of USE_SYSTEM_MALLOC	none

Konstantin Tokarev

Reported 2010-12-28 02:52:42 PST

Created attachment 77545 [details] Fixed usage of USE_SYSTEM_MALLOC Currently wtf/wtf.pri checks for USE_SYSTEM_MALLOC presence. However build-webkit script sets USE_SYSTEM_MALLOC=1 if --system-malloc key is added (compare with, e.g., ENABLE_GLIB_SUPPORT=1). This patch improves consistency of USE_SYSTEM_MALLOC usage across build system

Attachments
Fixed usage of USE_SYSTEM_MALLOC (2.51 KB, patch) 2010-12-28 02:52 PST, Konstantin Tokarev	eric: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Fixed usage of USE_SYSTEM_MALLOC (4.46 KB, patch) 2010-12-29 00:56 PST, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Fixed usage of USE_SYSTEM_MALLOC (4.48 KB, patch) 2010-12-29 01:03 PST, Konstantin Tokarev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-12-28 13:48:27 PST

Comment on attachment 77545 [details] Fixed usage of USE_SYSTEM_MALLOC OK. rs=me.

WebKit Commit Bot

Comment 2 2010-12-28 14:39:25 PST

Comment on attachment 77545 [details] Fixed usage of USE_SYSTEM_MALLOC Rejecting attachment 77545 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77545]" exit_code: 2 Last 500 characters of output: pdating working directory Processing patch 77545 from bug 51672. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Full output: http://queues.webkit.org/results/7320228

Konstantin Tokarev

Comment 3 2010-12-29 00:56:45 PST

Created attachment 77603 [details] Fixed usage of USE_SYSTEM_MALLOC The same patch with added changelogs

WebKit Review Bot

Comment 4 2010-12-29 00:58:21 PST

Attachment 77603 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'JavaScriptCore/ChangeLog', u'JavaScriptCore/wtf/wtf.pri', u'Tools/ChangeLog', u'Tools/DumpRenderTree/qt/DumpRenderTree.pro', u'Tools/WebKitTestRunner/qt/WebKitTestRunner.pro', u'WebKit.pri']" exit_code: 1 Tools/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Konstantin Tokarev

Comment 5 2010-12-29 01:03:36 PST

Created attachment 77604 [details] Fixed usage of USE_SYSTEM_MALLOC The same patch with fixed changelogs and whitespaces

David Kilzer (:ddkilzer)

Comment 6 2010-12-30 13:24:23 PST

Comment on attachment 77604 [details] Fixed usage of USE_SYSTEM_MALLOC r=me

WebKit Commit Bot

Comment 7 2010-12-30 15:48:01 PST

Comment on attachment 77604 [details] Fixed usage of USE_SYSTEM_MALLOC Clearing flags on attachment: 77604 Committed r74813: <http://trac.webkit.org/changeset/74813>

WebKit Commit Bot

Comment 8 2010-12-30 15:48:07 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.