Bug 51672 - [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is used
Summary: [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-28 02:52 PST by Konstantin Tokarev
Modified: 2010-12-30 15:48 PST (History)
2 users (show)

See Also:

Attachments
Fixed usage of USE_SYSTEM_MALLOC (2.51 KB, patch)
2010-12-28 02:52 PST, Konstantin Tokarev 		eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Fixed usage of USE_SYSTEM_MALLOC (4.46 KB, patch)
2010-12-29 00:56 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Fixed usage of USE_SYSTEM_MALLOC (4.48 KB, patch)
2010-12-29 01:03 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2010-12-28 02:52:42 PST 
Created attachment 77545 [details]
Fixed usage of USE_SYSTEM_MALLOC

Currently wtf/wtf.pri checks for USE_SYSTEM_MALLOC presence. However
build-webkit script sets USE_SYSTEM_MALLOC=1 if --system-malloc key is
added (compare with, e.g., ENABLE_GLIB_SUPPORT=1).
    
This patch improves consistency of USE_SYSTEM_MALLOC usage across build
system
Comment 1 Eric Seidel (no email) 2010-12-28 13:48:27 PST 
Comment on attachment 77545 [details]
Fixed usage of USE_SYSTEM_MALLOC

OK.  rs=me.
Comment 2 WebKit Commit Bot 2010-12-28 14:39:25 PST 
Comment on attachment 77545 [details]
Fixed usage of USE_SYSTEM_MALLOC

Rejecting attachment 77545 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77545]" exit_code: 2
Last 500 characters of output:
pdating working directory
Processing patch 77545 from bug 51672.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html

Full output: http://queues.webkit.org/results/7320228
Comment 3 Konstantin Tokarev 2010-12-29 00:56:45 PST 
Created attachment 77603 [details]
Fixed usage of USE_SYSTEM_MALLOC

The same patch with added changelogs
Comment 4 WebKit Review Bot 2010-12-29 00:58:21 PST 
Attachment 77603 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'JavaScriptCore/ChangeLog', u'JavaScriptCore/wtf/wtf.pri', u'Tools/ChangeLog', u'Tools/DumpRenderTree/qt/DumpRenderTree.pro', u'Tools/WebKitTestRunner/qt/WebKitTestRunner.pro', u'WebKit.pri']" exit_code: 1
Tools/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Konstantin Tokarev 2010-12-29 01:03:36 PST 
Created attachment 77604 [details]
Fixed usage of USE_SYSTEM_MALLOC

The same patch with fixed changelogs and whitespaces
Comment 6 David Kilzer (:ddkilzer) 2010-12-30 13:24:23 PST 
Comment on attachment 77604 [details]
Fixed usage of USE_SYSTEM_MALLOC

r=me
Comment 7 WebKit Commit Bot 2010-12-30 15:48:01 PST 
Comment on attachment 77604 [details]
Fixed usage of USE_SYSTEM_MALLOC

Clearing flags on attachment: 77604

Committed r74813: <http://trac.webkit.org/changeset/74813>
Comment 8 WebKit Commit Bot 2010-12-30 15:48:07 PST 
All reviewed patches have been landed.  Closing bug.