Bug 51667

Summary: JSON.stringify must exist as a function taking 3 parameters
Product: WebKit Reporter: Helder Correia <helder>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 51666    
Bug Blocks: 41876    
Attachments:
Description Flags
Patch none

Helder Correia
Reported 2010-12-27 21:56:08 PST
The reported function length is 1 instead.
Attachments
Patch (2.34 KB, patch)
2010-12-27 22:15 PST, Helder Correia
no flags
Helder Correia
Comment 1 2010-12-27 22:15:55 PST
Created attachment 77537 [details] Patch Diff is applied to patch 77536 from bug 51666.
Eric Seidel (no email)
Comment 2 2010-12-28 13:55:13 PST
Comment on attachment 77537 [details] Patch It appears it does actually take 3 values: // ECMA-262 v5 15.12.3 EncodedJSValue JSC_HOST_CALL JSONProtoFuncStringify(ExecState* exec) { if (!exec->argumentCount()) return throwVMError(exec, createError(exec, "No input to stringify")); JSValue value = exec->argument(0); JSValue replacer = exec->argument(1); JSValue space = exec->argument(2); return JSValue::encode(Stringifier(exec, replacer, space).stringify(value)); } We need to find a way to catch this class of bugs somehow.
WebKit Commit Bot
Comment 3 2010-12-28 14:44:26 PST
The commit-queue encountered the following flaky tests while processing attachment 77537 [details]: java/java-and-plugins.html bug 51690 (authors: ap@webkit.org and barraclough@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-12-28 14:45:32 PST
Comment on attachment 77537 [details] Patch Clearing flags on attachment: 77537 Committed r74727: <http://trac.webkit.org/changeset/74727>
WebKit Commit Bot
Comment 5 2010-12-28 14:45:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.