Bug 51661

Summary: ContextShadow should use AffineTransform instead of TransformationMatrix
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ariya.hidayat, commit-queue, eric, mdelaney7, mrobinson, sam, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Helder Correia
Reported 2010-12-27 17:40:57 PST
ContextShadow needs the CTM to make sure shadows are not affected by transformations when drawing on a canvas. AffineTransform is sufficient in this case.
Attachments
Patch (6.33 KB, patch)
2010-12-27 17:45 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2010-12-27 17:45:02 PST
Created attachment 77530 [details] Patch
Ariya Hidayat
Comment 2 2010-12-27 19:46:58 PST
Comment on attachment 77530 [details] Patch LGTM. re=me
Ariya Hidayat
Comment 3 2010-12-27 20:45:02 PST
Comment on attachment 77530 [details] Patch cq+
WebKit Commit Bot
Comment 4 2010-12-27 21:33:18 PST
Comment on attachment 77530 [details] Patch Clearing flags on attachment: 77530 Committed r74708: <http://trac.webkit.org/changeset/74708>
WebKit Commit Bot
Comment 5 2010-12-27 21:33:24 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-12-28 07:56:41 PST
http://trac.webkit.org/changeset/74708 might have broken Leopard Intel Debug (Tests)
Sam Weinig
Comment 7 2010-12-28 10:37:51 PST
It seem like the function name getTransformationMatrixFromContext really should be changed as well.
Helder Correia
Comment 8 2011-01-05 19:06:57 PST
(In reply to comment #7) > It seem like the function name getTransformationMatrixFromContext really should be changed as well. Just a follow-up: the function was removed in http://trac.webkit.org/changeset/74947
Note You need to log in before you can comment on or make changes to this bug.