Bug 51643

Summary: [WINCE] Provide 3rd party directory via environment variable
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
eric: review-
Patch darin: review-, darin: commit-queue-

Patrick R. Gansterer
Reported 2010-12-27 06:59:38 PST
see patch
Attachments
Patch (1.12 KB, patch)
2010-12-27 07:01 PST, Patrick R. Gansterer
eric: review-
Patch (1.13 KB, patch)
2011-01-03 13:30 PST, Patrick R. Gansterer
darin: review-
darin: commit-queue-
Patrick R. Gansterer
Comment 1 2010-12-27 07:01:48 PST
Eric Seidel (no email)
Comment 2 2010-12-28 14:00:06 PST
Comment on attachment 77503 [details] Patch This seems confusing. Since we already have a ThirdParty directory in our sources. Seems like this is a WINCE3RDPARTY directory or similar? Also, why not spell out THRID?
Patrick R. Gansterer
Comment 3 2010-12-28 14:05:19 PST
(In reply to comment #2) > (From update of attachment 77503 [details]) > This seems confusing. Since we already have a ThirdParty directory in our sources. Seems like this is a WINCE3RDPARTY directory or similar? Also, why not spell out THRID? IMHO it's not WinCE specific. Other (embedded) port, where you can't use the system libraries of the host, maybe need a 3rd party directory for png, jpeg, xml, ... too. It's ok to spell out, but we should change it everywhere in the CMake files. ;-)
Patrick R. Gansterer
Comment 4 2011-01-03 13:30:06 PST
Darin Adler
Comment 5 2011-01-03 13:32:07 PST
Comment on attachment 77840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77840&action=review > Sources/cmake/OptionsWinCE.cmake:14 > + IF (EXISTS $ENV{WEBKITTHRIDPARTYDIR}) > + SET(3RDPARTY_DIR $ENV{WEBKITTHRIDPARTYDIR}) Typo: THRID
Patrick R. Gansterer
Comment 6 2011-01-03 13:43:30 PST
(In reply to comment #5) > (From update of attachment 77840 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=77840&action=review > > > Sources/cmake/OptionsWinCE.cmake:14 > > + IF (EXISTS $ENV{WEBKITTHRIDPARTYDIR}) > > + SET(3RDPARTY_DIR $ENV{WEBKITTHRIDPARTYDIR}) > > Typo: THRID Good catch! Manually committed r74938: <http://trac.webkit.org/changeset/74938>
WebKit Review Bot
Comment 7 2011-01-03 16:18:48 PST
http://trac.webkit.org/changeset/74942 might have broken Windows Release (Build) and Windows Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.