Bug 51630

Summary: Move autotools into Sources
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51606    
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2010-12-26 22:27:20 PST
Move autotools into Tools
Attachments
Patch (27.13 KB, patch)
2010-12-26 22:29 PST, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-12-26 22:29:03 PST
Created attachment 77478 [details] Patch
Adam Barth
Comment 2 2010-12-26 22:29:43 PST
I don't fully understand how autotools works, so this patch is more of a guess.
Eric Seidel (no email)
Comment 3 2010-12-26 22:34:02 PST
Comment on attachment 77478 [details] Patch I guess I would have put such in some sort of build directory, but this is fine. :)
WebKit Review Bot
Comment 4 2010-12-26 22:34:15 PST
Attachment 77478 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7342020
Adam Barth
Comment 5 2010-12-26 22:35:22 PST
I was wondering about putting it in the Sources folder b/c that's where things like the XCode projects will be. The cmake folder is another example of this sort of thing.
Adam Barth
Comment 6 2010-12-26 22:50:03 PST
Chatting on IRC, Eric and I thought that Sources might be better because this stuff is more like the Xcode project than like build-webkit (which is really just a wrapper script).
Adam Barth
Comment 7 2010-12-26 23:26:09 PST
I tried landing this change in http://trac.webkit.org/changeset/74677. Hopefully the bots will complain if I screwed it up.
Note You need to log in before you can comment on or make changes to this bug.