Bug 51627

Summary: [Qt] Support for CSS color and background-color properties on select element's dropdown list
Product: WebKit Reporter: Xianlin Han <ext-xianlin.han>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, kling, laszlo.gombos
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
test html file
none
Proposed patch none

Xianlin Han
Reported 2010-12-26 18:39:36 PST
Webkit Qt Need support for css color and background-color properties on select element's dropdown list。 See Bug 9846. The same appearance, but I tried under Google Chrome, this bug do not reappear. So I think Bug 9846 may fixed. But Webkit Qt still have this problem.
Attachments
test html file (327 bytes, text/html)
2010-12-26 19:00 PST, Xianlin Han 		no flags
Details
Proposed patch (4.31 KB, patch)
2011-03-27 08:35 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianlin Han
Comment 1 2010-12-26 19:00:24 PST
Created attachment 77471 [details] test html file Add the test html file
Benjamin Poulain
Comment 2 2011-01-14 10:54:12 PST
Please follow this to report bugs on QtWebKit: http://trac.webkit.org/wiki/QtWebKitBugs Because you did not use the template, we did not have this bug in our list. Good catch otherwise. Thanks for attaching a test case as well.
Andreas Kling
Comment 3 2011-03-27 08:35:20 PDT
Created attachment 87071 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 4 2011-03-27 12:07:44 PDT
Comment on attachment 87071 [details] Proposed patch Looks ok, though I wonder how useful it is supporting this
Andreas Kling
Comment 5 2011-03-27 12:12:26 PDT
Comment on attachment 87071 [details] Proposed patch Clearing flags on attachment: 87071 Committed r82075: <http://trac.webkit.org/changeset/82075>
Andreas Kling
Comment 6 2011-03-27 12:12:33 PDT
All reviewed patches have been landed. Closing bug.
Laszlo Gombos
Comment 7 2011-03-27 23:35:45 PDT
I think together with this change we need to increment the version in qwebkitplatformplugin.h (to 1.8).
Note You need to log in before you can comment on or make changes to this bug.